[webkit-reviews] review denied: [Bug 27492] Web Sockets Test Infrastructure Part 3/3: Example test : [Attachment 34056] Example Web Socket Tests, same-origin and cross-origin.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 27492: Web Sockets Test Infrastructure Part 3/3: Example test
https://bugs.webkit.org/show_bug.cgi?id=27492

Attachment 34056: Example Web Socket Tests, same-origin and cross-origin.
https://bugs.webkit.org/attachment.cgi?id=34056&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Great that these are js tests!	Bad that you had to copy the files.  We really
should	fix bug 25915 instead.

ChangeLog is duplicated.

 13	debug('<span class="pass">TEST COMPLETE</span>');
is instead a testPassed() call.

Style:
 if (window.layoutTestController) {
 4     window.layoutTestController.waitUntilDone();
 5 }

description() is the right call here:
debug("NOOP Web Socket test");

r- for various nits above.