[webkit-reviews] review granted: [Bug 24887] Wrong filename when dragging an image to the Desktop. : [Attachment 34300] Patch, fixing 2 more issues from Darin

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jens Alfke <snej at chromium.org>'s
request for review:
Bug 24887: Wrong filename when dragging an image to the Desktop.
https://bugs.webkit.org/show_bug.cgi?id=24887

Attachment 34300: Patch, fixing 2 more issues from Darin
https://bugs.webkit.org/attachment.cgi?id=34300&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    value.replace("&", "&amp;");
> +    value.replace("\"", "&quot;");

There is a faster version of replace that takes a character for the first
parameter. You should use that.

> +    markup.append(" ");
> +    markup.append(name);
> +    markup.append("=\"");
> +    markup.append(value);
> +    markup.append("\"");

There is a version of append that takes a single character. You should use that
when possible.

> +    markup.append(">");

Here too.

> +}
> +    
> +
>  
>  } // namespace WebCore

Although there's no firm policy against it, I prefer not to add this additional
vertical space.

I guess we can live with this without any further testing. Normally we work
very hard to make such things testable when fixing bugs in them.

r=me