[webkit-reviews] review denied: [Bug 27491] Web Sockets Test Infrastructure Part 2/3: Patch to run-webkit-tests : [Attachment 34055] Patch to run-webkit-test to use Web Socket Server for both http and file schemes.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 27491: Web Sockets Test Infrastructure Part 2/3: Patch to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=27491

Attachment 34055: Patch to run-webkit-test to use Web Socket Server for both
http and file schemes.
https://bugs.webkit.org/attachment.cgi?id=34055&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please abstract:
8	  my $testPath = "$testDirectory/$test";
 639	     if (isCygwin()) {
 640		 $testPath = toWindowsPath($testPath);
 641	     } else {
 642		 $testPath = canonpath($testPath);
 643	     }

This is bad practice:
 1474	  mkdir "/tmp/WebKit";

It make it harder to run more than one copy in parallel.  Better to use a ~
relative path or at least a unique name.  I'm certain there are other examples
of such in run-webkit-tests.

That's a huge amount of code to make sure the server is dead.  Don't we already
have some of that for the httpd server?  Can't we share that?

r- for the needed abstraction.