[webkit-reviews] review denied: [Bug 26993] Geolocation::requestPermission() : [Attachment 34270] Patch 2 for bug 26993
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 7 12:39:14 PDT 2009
Eric Seidel <eric at webkit.org> has denied steveblock at google.com's request for
review:
Bug 26993: Geolocation::requestPermission()
https://bugs.webkit.org/show_bug.cgi?id=26993
Attachment 34270: Patch 2 for bug 26993
https://bugs.webkit.org/attachment.cgi?id=34270&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Why do we now have an unused argument? Seems we should at least be asserting,
no?
Why shoudn't makeSuccessCallbacks take an service parameter?
r- for the unexplained unused argument.
More information about the webkit-reviews
mailing list