[webkit-reviews] review denied: [Bug 26838] Multithread support for JSC on UNIX : [Attachment 33173] WebKit-r46156-Collector-multithread-support-for-UNIX.diff

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Martin Zoubek
<martin.zoubek at acision.com>'s request for review:
Bug 26838: Multithread support for JSC on UNIX
https://bugs.webkit.org/show_bug.cgi?id=26838

Attachment 33173: WebKit-r46156-Collector-multithread-support-for-UNIX.diff
https://bugs.webkit.org/attachment.cgi?id=33173&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
We really really need to use some sort o Threading abstraction for this stuff. 
Someone just posted a QNX patch which has similar #ifdef hacks.  Instead we
should have a ThreadingGtk and ThreadingQNX files which know how to get things
like stackbase.  Collector could then use those.

I don't think we can/should keep polluting Collector.cpp like this.  If Maciej
feels differently, he should feel completely welcome to r+ this patch, I will
not stand in your way if one of the more-regular JSC authors approves of this.