[webkit-reviews] review denied: [Bug 27431] splitting CodeGeneratorGObject.pm into library files : [Attachment 34289] updated from other review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 12:04:01 PDT 2009

Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27431: splitting CodeGeneratorGObject.pm into library files

Attachment 34289: updated from other review comments

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks like a big hack.  If we're going to do this, lets do it right.  No
commented out code.  No long lists of exclusions.  Nicely named methods which
actually follow WebKit style guidlines.  Small files that reviewers have a
chance of understanding.  Detailed ChangeLogs.	Use of sets/hashes instead of
long lists of copy/paste ifs.  

As is, either you're just looking for a rubber-stamp.  Or you don't realize how
much patches like this are just a waste of time.

Glad to have you contributing.	But if you're going to contribute to a product
as mature as WebKit, you need to expect to take a bit longer on your patches,
and write mature, well structured patches instead of hacks.

Contributing to a large project like WebKit is a lot of work. :)

More information about the webkit-reviews mailing list