[webkit-reviews] review denied: [Bug 28066] Avoid using TCmalloc in DumpRenderTree : [Attachment 34266] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 07:13:47 PDT 2009

Darin Adler <darin at apple.com> has denied Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 28066: Avoid using TCmalloc in DumpRenderTree

Attachment 34266: proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
This makes the class name RefCountedCustomAllocated seem pretty bad. After all,
there's no desire to "custom allocate" here.

I think we should consider doing this with the preprocessor instead of
different class names when we're talking about an entirely different binary
like DumpRenderTree, since USE_SYSTEM_MALLOC is already set. Can we investigate
that instead?

More information about the webkit-reviews mailing list