[webkit-reviews] review granted: [Bug 21605] Support for HTML5 "hashchange" event : [Attachment 34251] Fix + Layout Test

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 21605: Support for HTML5 "hashchange" event
https://bugs.webkit.org/show_bug.cgi?id=21605

Attachment 34251: Fix + Layout Test
https://bugs.webkit.org/attachment.cgi?id=34251&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    HashChangeEventTask(PassRefPtr<Document> document)
> +    : m_document(document)
> +    {
> +	   ASSERT(m_document);
> +    }

We normally indent that one tab stop.

> +    if (equalIgnoringRef(url, m_URL) && !equalIgnoringNullity(url.ref(),
m_URL.ref())) {
> +	   Document* currentDocument = frame()->document();
> +	  
currentDocument->postTask(HashChangeEventTask::create(currentDocument));
> +    }

If equalIgnoringRef(url, m_URL) ever false here?

r=me