[webkit-reviews] review granted: [Bug 27754] commit-log-editor does not produce a git commit log that is git friendly. : [Attachment 33602] commit-log-editor does not produce a git commit log that is git friendly.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Pierre d'Herbemont
<pdherbemont at free.fr>'s request for review:
Bug 27754: commit-log-editor does not produce a git commit log that is git
friendly.
https://bugs.webkit.org/show_bug.cgi?id=27754

Attachment 33602: commit-log-editor does not produce a git commit log that is
git friendly.
https://bugs.webkit.org/attachment.cgi?id=33602&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
So sad!  We have some parsing code like this in our python modules... Seems we
really should just re-write commit-log-editor in python (at least then we could
unit test it!)

Seems fine to me. :)  You might want to post to webkit-dev too so you can enjoy
some quality bike-shedding...

Glad to see more folks working on our tools.  I would strongly encourage you to
think about moving more of this code over to python in the future as our
scripts seem to be moving that way. :)