[webkit-reviews] review denied: [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption : [Attachment 33863] Proposed patch (rev.3)

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 27756: [HTML5][Forms] Part 2 of datalist&list: Support for
HTMLInputElement::list and HTMLInputElement::selectedOption
https://bugs.webkit.org/show_bug.cgi?id=27756

Attachment 33863: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=33863&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This is not safe:
 1811	  RefPtr<HTMLCollection> options =
static_cast<HTMLDataListElement*>(sourceElement)->options();
(at least not if we add more list() types).  I think until we add more list()
types we could just make it return HTMLDataListElement*.  But checking at each
callsite is OK too.

Seems this needs to be guarded by DATAGRID defines, no?  Or do we have a
DataList?  This doesn't look like a complete implementation, or?

I can't remember if you're a committer yet or not.  so r- assuming you'll need
someone else to land after you fix those nits.

This doesn't seem very useful w/o UI... but this is OK to land for now if it's
guarded by and ENABLE.