[webkit-reviews] review denied: [Bug 27619] Switch wx to using waf for builds : [Attachment 34096] Changes to build-webkit needed for wx to use the waf build process - second patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 18:48:45 PDT 2009


Eric Seidel <eric at webkit.org> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27619: Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 34096: Changes to build-webkit needed for wx to use the waf build
process - second patch
https://bugs.webkit.org/attachment.cgi?id=34096&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the huge wx() if block shoudl be moved elsewhere.  No need to make
build-webkit even bigger!  Maybe a function in webkitdirs.pm?  Maybe some sort
of ensureWafInstalled() or similar.


More information about the webkit-reviews mailing list