[webkit-reviews] review denied: [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. : [Attachment 34240] patch w/ manual test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 18:40:02 PDT 2009

Eric Seidel <eric at webkit.org> has denied Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 27889: [Chromium] RTL autocomplete popup is not layout correctly.

Attachment 34240: patch w/ manual test

------- Additional Comments from Eric Seidel <eric at webkit.org>
This constructor will run at library load time and slow down Chromium's launch
+static const String kEllipses = "...";

Style violation:
 55		: label(label), type(type), yOffset(0), ellipsesWidth(0) { }

 349	     if ( totalWidth > width)

Style violations, no argument names when not needed:
 410	     void drawBidiTextWithinWidth(const Font& font, const TextRun& run,
const FloatPoint& point, int width);

I don't think I can actually review the code here.  I would need to study these
files more.  r- for the style stuff.  Make sure to run check-webkit-style if
you haven't already. :)

More information about the webkit-reviews mailing list