[webkit-reviews] review requested: [Bug 28015] [Chromium] @font-face is not supported on Linux : [Attachment 34203] Proposed fix for 28015 (v2)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 6 10:54:02 PDT 2009
Adam Langley <agl at chromium.org> has asked for review:
Bug 28015: [Chromium] @font-face is not supported on Linux
https://bugs.webkit.org/show_bug.cgi?id=28015
Attachment 34203: Proposed fix for 28015 (v2)
https://bugs.webkit.org/attachment.cgi?id=34203&action=review
------- Additional Comments from Adam Langley <agl at chromium.org>
I'm not a WebKit reviewer, so I can't r+, but here are my comments:
> + This is chromium-only change. Support @font-face on Chromium Linux.
Change to: Chromium Linux: add support for @font-face
> + https://bugs.webkit.org/show_bug.cgi?id=28015
> + virtual size_t read(void* buffer, size_t size)
The return type of this function is obviously wrong, but I see that it's wrong
in Skia, so not your fault.
More information about the webkit-reviews
mailing list