[webkit-reviews] review requested: [Bug 27059] Exclude Symbian platform from define of MIDDLE_ENDIAN : [Attachment 34212] 2nd update of patch file for bug #27059

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 10:32:10 PDT 2009


Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27059: Exclude Symbian platform from define of MIDDLE_ENDIAN
https://bugs.webkit.org/show_bug.cgi?id=27059

Attachment 34212: 2nd update of patch file for bug #27059
https://bugs.webkit.org/attachment.cgi?id=34212&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
I agree with Darin'd comment of trying to avoid redefining variables with
beginning double underscores in the library code.

How about this updated patch:
Since on Symbian, we detect the __EABI__ variable but not __ARM_EABI__, I
simply added that flag to the respective (negative) conditional statements.
It's only in 2 places and I assume it is safe for any other platforms that may
or may not have this flag set.


More information about the webkit-reviews mailing list