[webkit-reviews] review requested: [Bug 24887] Wrong filename when dragging an image to the Desktop. : [Attachment 34076] New patch (by Jens)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 4 11:14:43 PDT 2009


Jens Alfke <snej at chromium.org> has asked  for review:
Bug 24887: Wrong filename when dragging an image to the Desktop.
https://bugs.webkit.org/show_bug.cgi?id=24887

Attachment 34076: New patch (by Jens)
https://bugs.webkit.org/attachment.cgi?id=34076&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
This is a new patch incorporating code from the previous one, but heavily
rewritten.
The core code for determining the filename has been moved to HTMLImageElement
so it can be used in other circumstances (such as Safari for Windows; I don't
feel competent to make the changes to hook it up for there, though.)
I've also implemented ClipboardChromium::validateFilename for the Mac platform.


I'm not aware of a way to create a layout test for this, since it would have to
involve simulating a drag out of the browser to the filesystem, and then
accessing the filesystem to check the name of the resulting file.


More information about the webkit-reviews mailing list