[webkit-reviews] review denied: [Bug 27984] cpp_style.py lacks checks for pointer and reference declaration style. : [Attachment 34072] Patch for cpp_style.py to check for pointer and reference marker placement.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27984: cpp_style.py lacks checks for pointer and reference declaration
style.
https://bugs.webkit.org/show_bug.cgi?id=27984

Attachment 34072: Patch for cpp_style.py to check for pointer and reference
marker placement.
https://bugs.webkit.org/attachment.cgi?id=34072&action=review

------- Additional Comments from David Levin <levin at chromium.org>
This needs unit tests (added to cpp_style_unittests.py)

Also, you could combine the regex and put them in a (named) group and then use
the result from the group in the printed error message.

Lastly, this guideline only applies to C++ code.  The tool also runs on C files
and the guideline is reversed in that case.  (int *i;)