[webkit-reviews] review granted: [Bug 25348] Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap. : [Attachment 29836] create(..) -> explicit ctor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 28 04:05:58 PDT 2009


Alexey Proskuryakov <ap at webkit.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 25348: Change WTF::ThreadIdentifier to be an actual (but wrapped) thread
id, remove ThreadMap.
https://bugs.webkit.org/show_bug.cgi?id=25348

Attachment 29836: create(..) -> explicit ctor
https://bugs.webkit.org/attachment.cgi?id=29836&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+    ThreadIdentifier(const ThreadIdentifier& another)
+	 : m_platformId(another.m_platformId)
+    {
+    }

Sorry, I didn't notice it before - if you are adding a non-default copy
constructor, you should also add a matching assignment operator. But since this
does the same as default one, I think that it can be simply removed.

You may need to also update MSVC JavaScriptCore exports, now that it's a
separate dll.

r=me


More information about the webkit-reviews mailing list