[webkit-reviews] review requested: [Bug 25443] Dashed/Dotted styled, odd width border lines are not rendered properly : [Attachment 29840] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 28 03:48:36 PDT 2009


Rohini Ananth <rohini.ananth at nokia.com> has asked  for review:
Bug 25443: Dashed/Dotted styled, odd width border lines are not rendered
properly
https://bugs.webkit.org/show_bug.cgi?id=25443

Attachment 29840: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=29840&action=review

------- Additional Comments from Rohini Ananth <rohini.ananth at nokia.com>
When drawLine() gets called for dotted/dashed border styles, avoid changing of
the co-ordinates of odd-width border lines in case of dotted/dashed border
styles [logic present inside adjustLineToPixelBoundaries() method] 
Without doing this, the other fix is to shift the element also[e.g. image in
drawImage()]in case of odd border width, but this doesn't seem like the correct
option.


More information about the webkit-reviews mailing list