[webkit-reviews] review requested: [Bug 25370] Introduce ScriptEventListener to abstract away attribute event listener creation. : [Attachment 29749] Refactor away direct refs to JSLazyEventListener, v1.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 10:54:24 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 25370: Introduce ScriptEventListener to abstract away attribute event
listener creation.
https://bugs.webkit.org/show_bug.cgi?id=25370

Attachment 29749: Refactor away direct refs to JSLazyEventListener, v1.
https://bugs.webkit.org/attachment.cgi?id=29749&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
 WebCore/ChangeLog			     |	 37 +++++++++++
 WebCore/GNUmakefile.am 		     |	  2 +
 WebCore/WebCore.pro			     |	  1 +
 WebCore/WebCore.vcproj/WebCore.vcproj	     |	  8 +++
 WebCore/WebCore.xcodeproj/project.pbxproj   |	  8 +++
 WebCore/bindings/js/JSDOMGlobalObject.cpp   |	  1 -
 WebCore/bindings/js/JSLazyEventListener.cpp |	 47 --------------
 WebCore/bindings/js/JSLazyEventListener.h   |	  4 -
 WebCore/bindings/js/ScriptController.cpp    |	  1 -
 WebCore/bindings/js/ScriptEventListener.cpp |	 92 +++++++++++++++++++++++++++
 WebCore/bindings/js/ScriptEventListener.h   |	 49 ++++++++++++++
 WebCore/bindings/v8/ScriptEventListener.cpp |	 61 ++++++++++++++++++
 WebCore/bindings/v8/ScriptEventListener.h   |	 49 ++++++++++++++
 WebCore/dom/Document.cpp		     |	  2 +-
 WebCore/html/HTMLBodyElement.cpp	     |	  2 +-
 WebCore/html/HTMLButtonElement.cpp	     |	  2 +-
 WebCore/html/HTMLElement.cpp		     |	  2 +-
 WebCore/html/HTMLFormElement.cpp	     |	  2 +-
 WebCore/html/HTMLFrameElementBase.cpp	     |	  2 +-
 WebCore/html/HTMLFrameSetElement.cpp	     |	  2 +-
 WebCore/html/HTMLImageElement.cpp	     |	  2 +-
 WebCore/html/HTMLInputElement.cpp	     |	  2 +-
 WebCore/html/HTMLObjectElement.cpp	     |	  2 +-
 WebCore/html/HTMLScriptElement.cpp	     |	  2 +-
 WebCore/html/HTMLSelectElement.cpp	     |	  2 +-
 WebCore/html/HTMLTextAreaElement.cpp	     |	  2 +-
 WebCore/svg/SVGElement.cpp		     |	  2 +-
 WebCore/svg/SVGSVGElement.cpp		     |	  2 +-
 28 files changed, 322 insertions(+), 68 deletions(-)


More information about the webkit-reviews mailing list