[webkit-reviews] review requested: [Bug 24168] RTL: Home/End key does not behave correctly in mixed bidi text in RTL document : [Attachment 29748] patch w/ Layout test (version 5)

[bugzilla-daemon at webkit.org]

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 24168: RTL: Home/End key does not behave correctly in mixed bidi text in
RTL document
https://bugs.webkit.org/show_bug.cgi?id=24168

Attachment 29748: patch w/ Layout test (version 5)
https://bugs.webkit.org/attachment.cgi?id=29748&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
I've incorporated all the changes except that:

1. I am leaving the following block in logicalStartOfLine()
    // Make sure the start of line is not greater than the given input
position.  ....
    Position p = visPos.deepEquivalent();
    if (p.m_offset > c.deepEquivalent().m_offset &&
p.node()->isSameNode(c.deepEquivalent().node())) {
	....
    }

2. I changed the inSameLogicalLine() block in logicalEndOfLine() to
    if (!inSameLogicalLine(c, visPos))
	visPos = visPos.previous();

Thanks,
Xiaomei