[webkit-reviews] review denied: [Bug 15616] [GTK] Add spell checking : [Attachment 29703] 0004-Implement-ignore-learn-and-guesses.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied 's request for review:
Bug 15616: [GTK] Add spell checking
https://bugs.webkit.org/show_bug.cgi?id=15616

Attachment 29703: 0004-Implement-ignore-learn-and-guesses.patch
https://bugs.webkit.org/attachment.cgi?id=29703&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>

> +    GSList* langs;
> +    langs = webkit_web_settings_get_spell_languages(m_webView);

Same line.

> +    for (; langs; langs = langs->next)
> +    {

Brace should go on the previous line; there are other instances of this I
forgot to complain about.

> +	   lang = (SpellLanguage*) langs->data;

Cast and initialiation on same line.

> +    for (; langs; langs = langs->next)
> +    {

Brace.

> +	   SpellLanguage* lang;
> +	   gchar** suggestions;
> +	   size_t n_suggestions;

numberOfSuggestions

> +	   size_t i;
> +
> +	   lang = (SpellLanguage*) langs->data;

Initialization/cast.

> +	       for (i = 0; i < n_suggestions && i < 10; i++)
> +	       {
> +		   String string = String::fromUTF8(suggestions[i]);
> +		   guesses.append(string);

No need to declare the variable. Make that guesses.append(String::from...).