[webkit-reviews] review denied: [Bug 15616] [GTK] Add spell checking : [Attachment 29702] 0003-Implement-checkSpellingOfString.patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 23 19:30:52 PDT 2009
Gustavo Noronha (kov) <gns at gnome.org> has denied 's request for review:
Bug 15616: [GTK] Add spell checking
https://bugs.webkit.org/show_bug.cgi?id=15616
Attachment 29702: 0003-Implement-checkSpellingOfString.patch
https://bugs.webkit.org/attachment.cgi?id=29702&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +/* vim: set sw=4 ts=4 sts=4 et: */
No marking for this patch, though I would welcome vim/emacs markings in a
separate patch.
> + PangoLanguage* language;
> + PangoLogAttr* attrs = g_new(PangoLogAttr, utflen+1);
What's this +1 for? A comment will do.
> + int orig_mispellingLocation = *misspellingLocation;
> + int orig_mispellingLength = *misspellingLength;
Make these originalMispellingLocation/Length.
> + int start;
> + int end;
> + int word_length;
wordLength
> + lang = (SpellLanguage*) langs->data;
Use a C++-style cast here: static_cast<SpellLanguage*>(langs->data).
> + cstart = g_utf8_offset_to_pointer(ctext, start);
> + bytes = (gint) (g_utf8_offset_to_pointer(ctext, end) -
cstart);
Same here.
> + result = enchant_dict_check(lang->speller, word, -1);
> + if (result > 0)
> + {
> + *misspellingLocation = start;
> + *misspellingLength = word_length;
> + }
> + if (result == 0)
> + {
Make that
if (re...) {
...
} else if (...) {
...
}
> --- a/WebKit/gtk/WebCoreSupport/EditorClientGtk.h
> +++ b/WebKit/gtk/WebCoreSupport/EditorClientGtk.h
> @@ -33,6 +33,7 @@
> #include "EditorClient.h"
>
> #include <wtf/Forward.h>
> +#include <glib.h>
This should go in the .cpp, right after Frame.h?
More information about the webkit-reviews
mailing list