[webkit-reviews] review granted: [Bug 12440] repaints inconsistent or draw incorrect with fixed position elements : [Attachment 29344] Better patch that doesn't turn off the optimization.

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 12440: repaints inconsistent or draw incorrect with fixed position elements
https://bugs.webkit.org/show_bug.cgi?id=12440

Attachment 29344: Better patch that doesn't turn off the optimization.
https://bugs.webkit.org/attachment.cgi?id=29344&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   if (sendContentResizedNotification && m_inUpdateScrollbarsPass < 2)
{

I think you should store "2" in a named constant.

> +	   if (suppressScrollers) {
> +	       [[self verticalScroller] setNeedsDisplay: NO];
> +	       [[self horizontalScroller] setNeedsDisplay: NO];
>	   }

I think we don't normally leave spaces after colons in ObjC method calls.

r=me