[webkit-reviews] review granted: [Bug 12440] repaints inconsistent or draw incorrect with fixed position elements : [Attachment 29345] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 8 15:05:05 PDT 2009


Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 12440: repaints inconsistent or draw incorrect with fixed position elements
https://bugs.webkit.org/show_bug.cgi?id=12440

Attachment 29345: Patch
https://bugs.webkit.org/attachment.cgi?id=29345&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  #if USE(ACCELERATED_COMPOSITING)
> +    if (view()) {
> +	   bool layoutPending = view()->layoutPending() ||
renderer()->needsLayout();
> +	   // If we didn't update compositing layers because of layout(), we
need to do so here.
> +	   if (!layoutPending)
> +	       view()->updateCompositingLayers();
>      }
> +#endif

This comment no longer makes sense, because there's no call to layout() any
more.

Otherwise, r=me


More information about the webkit-reviews mailing list