[webkit-reviews] review requested: [Bug 25087] Test ENABLE_FOO macros consistently in IDL files : [Attachment 29322] Patch v1

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 25087: Test ENABLE_FOO macros consistently in IDL files
https://bugs.webkit.org/show_bug.cgi?id=25087

Attachment 29322: Patch v1
https://bugs.webkit.org/attachment.cgi?id=29322&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Proposed fix.

All the ports appear to be using the generate-bindings.pl script and only
defining macros if they intend the feature to be enabled, so I propose
changing:

#if ENABLE_FOO

to:

#if defined(ENABLE_FOO)

rather than:

#if defined(ENABLE_FOO) && ENABLE_FOO

Since there is currently a mix of the first two (and there are no apparent
build issues), I think this is safe to do.  Comments?