[webkit-reviews] review requested: [Bug 25087] Test ENABLE_FOO macros consistently in IDL files : [Attachment 29322] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 7 17:56:07 PDT 2009

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 25087: Test ENABLE_FOO macros consistently in IDL files

Attachment 29322: Patch v1

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Proposed fix.

All the ports appear to be using the generate-bindings.pl script and only
defining macros if they intend the feature to be enabled, so I propose



#if defined(ENABLE_FOO)

rather than:

#if defined(ENABLE_FOO) && ENABLE_FOO

Since there is currently a mix of the first two (and there are no apparent
build issues), I think this is safe to do.  Comments?

More information about the webkit-reviews mailing list