[webkit-reviews] review requested: [Bug 24527] caret does not paint the first time you focus on a 0px right padding RTL div : [Attachment 29321] patch w/ Layout test (version 2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 7 17:54:59 PDT 2009


Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 24527: caret does not paint the first time you focus on a 0px right padding
RTL div
https://bugs.webkit.org/show_bug.cgi?id=24527

Attachment 29321: patch w/ Layout test (version 2)
https://bugs.webkit.org/attachment.cgi?id=29321&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
Hi Simon,

Could you kindly give it a review again?

Following are the changes comparing with first version patch.
1. add explanation in ChangLog.
2. changed the x-axis to be minus by caretWidth. Tested in Safari using
caretWidth=10, and yes, the x-axis should be minus by caretWidth, not by 1.
Thanks mitz to point out the right place.


More information about the webkit-reviews mailing list