[webkit-reviews] review denied: [Bug 25027] JavaScript parseInt wrong on negative numbers : [Attachment 29250] Simple patch for the issue
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 6 11:50:23 PDT 2009
Sam Weinig <sam at webkit.org> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 25027: JavaScript parseInt wrong on negative numbers
https://bugs.webkit.org/show_bug.cgi?id=25027
Attachment 29250: Simple patch for the issue
https://bugs.webkit.org/attachment.cgi?id=29250&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
> - return jsNumber(exec, floor(d));
> + return jsNumber(exec, (d > 0)?floor(d):ceil(d));
Our style dictates that there should be spaces around the ? and :
More information about the webkit-reviews
mailing list