[webkit-reviews] review requested: [Bug 20422] Patch to allow custom memory allocation control : [Attachment 29285] Same patch as before, updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 6 11:48:41 PDT 2009


Zoltan Horvath <Horvath.Zoltan.6 at stud.u-szeged.hu> has asked  for review:
Bug 20422: Patch to allow custom memory allocation control
https://bugs.webkit.org/show_bug.cgi?id=20422

Attachment 29285: Same patch as before, updated
https://bugs.webkit.org/attachment.cgi?id=29285&action=review

------- Additional Comments from Zoltan Horvath
<Horvath.Zoltan.6 at stud.u-szeged.hu>
> * The change in WebCore/ForwardingHeaders/wtf/TypeTraits.h looks wrong and
> seems like it should not be done (along with the corresponding ChangeLog).

Done.

> * The // -*- mode: c++; c-basic-offset: 4 -*- at the top of
> JavaScriptCore/wtf/FastAllocBase.h isn't typical style.

Done.

Three other smart correction in FastAllocBase.h: 
- in line 291: "WTF::has_trivial_constructor" replaced to 
"WTF::HasTrivialConstructor" and 
"WTF::has_trivial_destructor" replaced to "WTF::HasTrivialDestructor"
- in line 347: "WTF::has_trivial_destructor" replaced to
"WTF::HasTrivialDestructor"
- in line 396: "WTF::has_trivial_destructor" replaced to
"WTF::HasTrivialDestructor"

Others are unchanged.


More information about the webkit-reviews mailing list