[webkit-reviews] review requested: [Bug 25059] Remove references to dominantScript, getGenericFontForScript : [Attachment 29283] 2009-04-06 Mike Belshe <mike at belshe.com>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 6 11:25:23 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 25059: Remove references to dominantScript, getGenericFontForScript
https://bugs.webkit.org/show_bug.cgi?id=25059

Attachment 29283: 2009-04-06  Mike Belshe  <mike at belshe.com>
https://bugs.webkit.org/attachment.cgi?id=29283&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>

	Reviewed by Dimitri Glazkov.

	https://bugs.webkit.org/show_bug.cgi?id=24978
	Use custom implementations of a few Node methods so that
	we don't over-aggressively create JS wrappers here.

	* bindings/v8/custom/V8NodeCustom.cpp: Added custom implementations.
	* dom/Node.idl: Removed JSC-specifier, making impl custom for V8 as
well.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42248
268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 WebCore/ChangeLog			     |	 11 ++++
 WebCore/bindings/v8/custom/V8NodeCustom.cpp |	 74 +++++++++++++++++++++++++++
 WebCore/dom/Node.idl			     |	  8 ++--
 3 files changed, 89 insertions(+), 4 deletions(-)


More information about the webkit-reviews mailing list