[webkit-reviews] review requested: [Bug 25059] Remove references to dominantScript, getGenericFontForScript : [Attachment 29282] WebCore:

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 25059: Remove references to dominantScript, getGenericFontForScript
https://bugs.webkit.org/show_bug.cgi?id=25059

Attachment 29282: WebCore:
https://bugs.webkit.org/attachment.cgi?id=29282&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>

2009-04-06  Dave Moore	<davemoore at google.com>

	Reviewed by Dimitri Glazkov.

	https://bugs.webkit.org/show_bug.cgi?id=25031
	Make the V8 element collections check for named properties *before*
	checking if there are any elements with the same name. Otherwise
	it is both incorrect and slow.

	Test: fast/dom/HTMLSelectElement/length-not-overridden.html

	Both of these interceptors were attempting to find an element in the
	collection that had a name or id of the property name before checking
	for a JS property with that name.
	* bindings/v8/V8Collection.h:
	(WebCore::collectionNamedPropertyGetter):
	(WebCore::nodeCollectionNamedPropertyGetter):

LayoutTests:

2009-04-06  Dave Moore	<davemoore at google.com>

	Reviewed by Dimitri Glazkov.

	https://bugs.webkit.org/show_bug.cgi?id=25031
	Test for ensuring that named elements don't override properties on
collections

	* fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added.
	* fast/dom/HTMLSelectElement/length-not-overridden.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42247
268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 LayoutTests/ChangeLog				    |	10 +++++
 .../length-not-overridden-expected.txt 	    |	 4 ++
 .../HTMLSelectElement/length-not-overridden.html   |	37 ++++++++++++++++++++
 WebCore/ChangeLog				    |	18 +++++++++
 WebCore/bindings/v8/V8Collection.h		    |	18 +++++++++
 5 files changed, 87 insertions(+), 0 deletions(-)