[webkit-reviews] review requested: [Bug 25059] Remove references to dominantScript, getGenericFontForScript : [Attachment 29281] 2009-04-06 Simon Fraser <simon.fraser at apple.com>

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 25059: Remove references to dominantScript, getGenericFontForScript
https://bugs.webkit.org/show_bug.cgi?id=25059

Attachment 29281: 2009-04-06  Simon Fraser  <simon.fraser at apple.com>
https://bugs.webkit.org/attachment.cgi?id=29281&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>

	Reviewed by Darin Adler

	https://bugs.webkit.org/show_bug.cgi?id=25052

	Pull the call to updateGraphicsLayerGeometry() out of
updateGraphicsLayers(),
	because we need to call it at the end of rebuildCompositingLayerTree()
once
	we've determined which descendant layers are composited, otherwise
	calculateCompositedBounds() can give the wrong answer.

	Now that updateLayerCompositingState() doesn't end up calling
updateGraphicsLayerGeometry(),
	call that explicitly from styleChanged(), if we know a layer update is
not pending,
	and similarly from updateAfterLayout().

	Test: compositing/overflow/overflow-positioning.html

	* rendering/RenderLayer.cpp:
	(WebCore::RenderLayer::styleChanged):
	* rendering/RenderLayerBacking.cpp:
	(WebCore::RenderLayerBacking::updateAfterLayout):
	(WebCore::RenderLayerBacking::updateGraphicsLayers):
	(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
	* rendering/RenderLayerCompositor.cpp:
	(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42246
268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 LayoutTests/ChangeLog				    |	11 +++
 .../compositing/overflow/overflow-positioning.html |	86 ++++++++++++++++++++
 .../overflow-positioning-expected.checksum	    |	 1 +
 .../overflow/overflow-positioning-expected.png     |  Bin 0 -> 16400 bytes
 .../overflow/overflow-positioning-expected.txt     |	14 +++
 WebCore/ChangeLog				    |	26 ++++++
 WebCore/rendering/RenderLayer.cpp		    |	 2 +
 WebCore/rendering/RenderLayerBacking.cpp	    |	14 +---
 WebCore/rendering/RenderLayerCompositor.cpp	    |	 7 +-
 9 files changed, 149 insertions(+), 12 deletions(-)