[webkit-reviews] review granted: [Bug 25001] Crash when content type parameters have no value : [Attachment 29189] Handle the case where a Content-Type header parameter has no value

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 2 08:15:29 PDT 2009


Alexey Proskuryakov <ap at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 25001: Crash when content type parameters have no value
https://bugs.webkit.org/show_bug.cgi?id=25001

Attachment 29189: Handle the case where a Content-Type header parameter has no
value
https://bugs.webkit.org/attachment.cgi?id=29189&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me, because this just fixes a crash, but I really, really dislike removing
const from "const char*" here. A quick web search suggests that
soup_header_g_string_append_param takes const char* parameters, so there should
be no reason to do make such unsafe conversions.


More information about the webkit-reviews mailing list