[webkit-reviews] review granted: [Bug 24844] Unit test WebKitDownload : [Attachment 29163] Fixes for the crash and critical message detected by the unit tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 2 08:12:26 PDT 2009
Alexey Proskuryakov <ap at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 24844: Unit test WebKitDownload
https://bugs.webkit.org/show_bug.cgi?id=24844
Attachment 29163: Fixes for the crash and critical message detected by the unit
tests
https://bugs.webkit.org/attachment.cgi?id=29163&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> + Extra checks to avoid crashing and a critical message when
> + property accessor functions are called before the download is
> + started.
Tabs instead of spaces here.
> + if (!priv->timer)
> + return 0.0;
I'd just write "return 0".
r=me
More information about the webkit-reviews
mailing list