[webkit-reviews] review granted: [Bug 21030] The JS debugger breaks on the do of a do-while not the while (where the conditional statement is) : [Attachment 23710] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 23 11:28:20 PDT 2008


Darin Adler <darin at apple.com> has granted Kevin McCullough
<kmccullough at apple.com>'s request for review:
Bug 21030: The JS debugger breaks on the do of a do-while not the while (where
the conditional statement is)
https://bugs.webkit.org/show_bug.cgi?id=21030

Attachment 23710: Patch
https://bugs.webkit.org/attachment.cgi?id=23710&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

Is there any way to do automated testing of debugger hook changes?

+	 * kjs/nodes.h:
+	 (JSC::StatementNode::):
+	 (JSC::DoWhileNode::):

This is kind of weak. When prepare-ChangeLog puts nonsense in the ChangeLog you
should fix it instead of just checking it in.


More information about the webkit-reviews mailing list