[webkit-reviews] review denied: [Bug 20664] [GTK] File names are not always encodable in UTF-8 : [Attachment 23350] Add filenameToString and filenameFromString to FileSystemGtk.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 13 09:18:59 PDT 2008


Alp Toker <alp at nuanti.com> has denied Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 20664: [GTK] File names are not always encodable in UTF-8
https://bugs.webkit.org/show_bug.cgi?id=20664

Attachment 23350: Add filenameToString and filenameFromString to
FileSystemGtk.cpp
https://bugs.webkit.org/attachment.cgi?id=23350&action=edit

------- Additional Comments from Alp Toker <alp at nuanti.com>
+#if PLATFORM(WIN)

should be WIN_OS.

g_uri_escape_string()

^ only available in GLib >= 2.16


For this change to make sense, we need to decide exactly what we expect the
developer to pass to user-stylesheet-uri: a local filename (byte array) or a
well formatted URI?


More information about the webkit-reviews mailing list