[webkit-reviews] review denied: [Bug 20534] DumpRenderTree needs a way to override settings on a per-test basis : [Attachment 23328] Improved possible patch to issue 20534
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 13 06:59:32 PDT 2008
Timothy Hatcher <timothy at hatcher.name> has denied Glenn Wilson
<gwilson at google.com>'s request for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534
Attachment 23328: Improved possible patch to issue 20534
https://bugs.webkit.org/attachment.cgi?id=23328&action=edit
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
You can't change WebPreferences.h (Mac) since that is a public framework
header. Any changes to those public headers need formal API review first.
The correct change is to put things in WebPreferencesPrivate.h, until they can
someday be made public.
r- because of this. I didn't review the rest.
More information about the webkit-reviews
mailing list