[webkit-reviews] review denied: [Bug 20664] [GTK] File names are not always encodable in UTF-8 : [Attachment 23191] Add String::toFilename and String::fromFilename

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 5 11:31:26 PDT 2008

Darin Adler <darin at apple.com> has denied Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 20664: [GTK] File names are not always encodable in UTF-8

Attachment 23191: Add String::toFilename and String::fromFilename

------- Additional Comments from Darin Adler <darin at apple.com>
Adding this capability to the String class seems clearly wrong. It's not
correct layering -- we don't want the String class to know anything about the
file system. We also want to limit platform-specific functions in the String
class to the ones for converting to and from platform String types.

You can accomplish this by building functions that operate on String objects
rather than adding member functions to the String class itself.

I believe this can be done entirely within the FileSystemGtk.cpp file without
touching PlatformString.h or String.cpp.

More information about the webkit-reviews mailing list