[webkit-reviews] review denied: [Bug 20667] Animation of -webkit-transform matrix() function should not do linear interpolation : [Attachment 23195] Patch to fix bug

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 20667: Animation of -webkit-transform matrix() function should not do
linear interpolation
https://bugs.webkit.org/show_bug.cgi?id=20667

Attachment 23195: Patch to fix bug
https://bugs.webkit.org/attachment.cgi?id=23195&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
Just style nits.

+    double sx, sy;
+    double angle;
We don't usually pre declare variables.

+    /* Compute scaling factors. */
We tend to use C++ style comments.  This issue is in a few 

+    sx = sqrt (m.a() * m.a() + m.b() * m.b());
+    sy = sqrt (m.c() * m.c() + m.d() * m.d());
Space after sqrt.

+    angle = atan2 (m.b(), m.a());
Space after atan2.

+    int i;
No need to pre declare this.

+	 srA[2] += srA[2] < 0 ? M_PI : -M_PI;
+    }
+
+    // Don't rotate the long way around.
+    srA[2] = fmod(srA[2], 2.0 * M_PI);
+    srB[2] = fmod(srB[2], 2.0 * M_PI);
+
+    if (fabs (srA[2] - srB[2]) > M_PI) {
+	 if (srA[2] > srB[2])
+	     srA[2] -= M_PI * 2.0;
+	 else
+	     srB[2] -= M_PI * 2.0;
+    }
We use piDouble/piFloat instead of M_PI