[webkit-reviews] review denied: [Bug 20620] Wrap uses of KJS in core classes with USE(JAVASCRIPTCORE_BINDINGS) : [Attachment 23149] Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Eric Seidel <eric at webkit.org>'s request
for review:
Bug 20620: Wrap uses of KJS in core classes with USE(JAVASCRIPTCORE_BINDINGS)
https://bugs.webkit.org/show_bug.cgi?id=20620

Attachment 23149: Clean up Platform.h and add PLATFORM(CHROMIUM),
PLATFORM(SKIA) and USE(V8_BINDINGS)
https://bugs.webkit.org/attachment.cgi?id=23149&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
This comment is not necessary.	
+/* Chromium runs WebKit multi-process/sandboxed, and provides its own */
+/* OS-level abstractions to work in this environment. */

Will this break windows builds that use CG?
+/* Makes PLATFORM(WIN) default to PLATFORM(CAIRO) */
+#if !PLATFORM(MAC) && !PLATFORM(QT) && !PLATFORM(WX)

Why not do this in Platform.h
+#if !defined(WTF_USE_JAVASCRIPTCORE_BINDINGS) && !defined(WTF_USE_V8_BINDINGS)

+/* Currently Chromium is the only platform which uses V8 by default */
+#if PLATFORM(CHROMIUM)
+#define WTF_USE_JAVASCRIPTCORE_BINDINGS 0
+#define WTF_USE_V8_BINDINGS 1
+#else
+#define WTF_USE_JAVASCRIPTCORE_BINDINGS 1
+#define WTF_USE_V8_BINDINGS 0
+#endif /* PLATFORM(CHROMIUM) */
+#endif /* !defined(WTF_USE_JAVASCRIPTCORE_BINDINGS) &&
!defined(WTF_USE_V8_BINDINGS) */

Why is this change ok?
-#define ENABLE_NETSCAPE_PLUGIN_API 0
+#define ENABLE_NETSCAPE_PLUGIN_API 1