[webkit-reviews] review requested: [Bug 20620] Wrap uses of KJS in core classes with USE(JAVASCRIPTCORE_BINDINGS) : [Attachment 23149] Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 3 14:45:00 PDT 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 20620: Wrap uses of KJS in core classes with USE(JAVASCRIPTCORE_BINDINGS)
https://bugs.webkit.org/show_bug.cgi?id=20620

Attachment 23149: Clean up Platform.h and add PLATFORM(CHROMIUM),
PLATFORM(SKIA) and USE(V8_BINDINGS)
https://bugs.webkit.org/attachment.cgi?id=23149&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 JavaScriptCore/ChangeLog			    |	10 +++++
 .../Configurations/JavaScriptCore.xcconfig	    |	 2 +-
 JavaScriptCore/wtf/ASCIICType.h		    |	 1 +
 JavaScriptCore/wtf/Platform.h			    |	37 +++++++++++++-------
 WebCore/ChangeLog				    |	 9 +++++
 WebCore/Configurations/WebCore.xcconfig	    |	 2 +-
 WebCore/config.h				    |	21 ++++++-----
 WebKit/mac/ChangeLog				    |	 9 +++++
 WebKit/mac/Configurations/WebKit.xcconfig	    |	 2 +-
 WebKit/mac/WebKitPrefix.h			    |	 5 +++
 10 files changed, 72 insertions(+), 26 deletions(-)


More information about the webkit-reviews mailing list