[webkit-reviews] review denied: [Bug 21924] HashTable internal index is not always deleted : [Attachment 24714] fix a memory leak on HashTable

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Frederic Marmond
<fmarmond at pleyo.com>'s request for review:
Bug 21924: HashTable internal index is not always deleted
https://bugs.webkit.org/show_bug.cgi?id=21924

Attachment 24714: fix a memory leak on HashTable
https://bugs.webkit.org/attachment.cgi?id=24714&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
HashTable::deleteTable is called from JSGlobalData destructor to avoid having
destructors for static objects, which this patch would introduce.

However, the problem is real - in WebCore/bindings/js/JSDOMBinding.cpp,
DOMObjectHashTableMap isn't properly cleaned up! This only affects worker
threads though.