[webkit-reviews] review requested: [Bug 21883] [CAIRO] globalAlpha has to be stored and restored : [Attachment 24717] save/restore globalAlpha

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 28 09:14:45 PDT 2008

Dirk Schulze <vbs85 at gmx.de> has asked  for review:
Bug 21883: [CAIRO] globalAlpha has to be stored and restored

Attachment 24717: save/restore globalAlpha

------- Additional Comments from Dirk Schulze <vbs85 at gmx.de>
(In reply to comment #3)
> GraphicsContext already keeps a stack with internal state (see
> GraphicsContext.cpp GraphicsContext::save() and GraphicsContextPrivate.h). I
> was thinking it might be better to add an 'alpha' field to that and let
> GraphicsContext do the work for us so we don't need to maintain our own stack

> of alpha values for GraphicsContextCairo. Could you take a look into that?

I spoke to esedeidel via IRC as I implemented the current version of
globalAlpha. And he didn't like the idea to change GraphicsContextPrivate.h. A
globalAlpha variable is only needed on cairo and would waste space for other
Or we use #if PLATFORM(CAIRO).

This second patch uses the alternative. Only One patch should be reviewed.

More information about the webkit-reviews mailing list