[webkit-reviews] review requested: [Bug 21816] Clean up ImageBuffer.h so there do not have to be separate ifdefs for each platform : [Attachment 24695] Patch v3

[bugzilla-daemon at webkit.org]

Brett Wilson (Google) <brettw at chromium.org> has asked  for review:
Bug 21816: Clean up ImageBuffer.h so there do not have to be separate ifdefs
for each platform
https://bugs.webkit.org/show_bug.cgi?id=21816

Attachment 24695: Patch v3
https://bugs.webkit.org/attachment.cgi?id=24695&action=edit

------- Additional Comments from Brett Wilson (Google) <brettw at chromium.org>
The implements Darin's suggestion of deleting the ::create function and making
the constructor use an out parameter. I had to change a lot of callers, some of
which improved in clarity, some of which got slightly worse as a result of this
change. The code in ImageBuffer*.cpp is much shorter.

This adds a one-line ifdef change to allow Skia ports to implement text drawing
modes (the change in GraphicsContext.cc).