[webkit-reviews] review granted: [Bug 21900] wx port doesn't draw text caret : [Attachment 24688] fix caret drawing in the wx port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 27 14:47:22 PDT 2008


Kevin Ollivier <kevino at theolliviers.com> has granted Kevin Watters
<kevinwatters at gmail.com>'s request for review:
Bug 21900: wx port doesn't draw text caret
https://bugs.webkit.org/show_bug.cgi?id=21900

Attachment 24688: fix caret drawing in the wx port
https://bugs.webkit.org/attachment.cgi?id=24688&action=edit

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
> diff --git a/WebKit/wx/ChangeLog b/WebKit/wx/ChangeLog
> index 3d105b4..1a6e911 100644
> --- a/WebKit/wx/ChangeLog
> +++ b/WebKit/wx/ChangeLog
> @@ -1,3 +1,14 @@
> +2008-10-27  Kevin Watters  <kevinwatters at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +	   
> +	   Update the active state as well as the focused state as both need to
be true
> +	   for the caret to be drawn.
> +
> +	   * WebView.cpp:
> +	   (wxWebView::OnSetFocus):
> +	   (wxWebView::OnKillFocus):
> +
>  2008-10-25  Kevin Ollivier  <kevino at theolliviers.com>
>  
>	   wx build fix.
> diff --git a/WebKit/wx/WebView.cpp b/WebKit/wx/WebView.cpp
> index 0c4cb66..546518f 100644
> --- a/WebKit/wx/WebView.cpp
> +++ b/WebKit/wx/WebView.cpp
> @@ -564,8 +564,10 @@ void wxWebView::OnSetFocus(wxFocusEvent& event)
>      if (m_mainFrame)
>	   frame = m_mainFrame->GetFrame();
>	   
> -    if (frame)
> +    if (frame) {
> +	   m_impl->page->focusController()->setActive(true);
>	   frame->selection()->setFocused(true);
> +    }
>  
>      event.Skip();
>  }
> @@ -576,9 +578,10 @@ void wxWebView::OnKillFocus(wxFocusEvent& event)
>      if (m_mainFrame)
>	   frame = m_mainFrame->GetFrame();
>	   
> -    if (frame)
> +    if (frame) {
> +	   m_impl->page->focusController()->setActive(false);
>	   frame->selection()->setFocused(false);
> -
> +    }
>      event.Skip();
>  }
>


More information about the webkit-reviews mailing list