[webkit-reviews] review granted: [Bug 18703] changing the 'size' property on a text input does not affect its length : [Attachment 24621] Possible patch to bug 18703.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Glenn Wilson <gwilson at google.com>'s
request for review:
Bug 18703: changing the 'size' property on a text input does not affect its
length
https://bugs.webkit.org/show_bug.cgi?id=18703

Attachment 24621: Possible patch to bug 18703.
https://bugs.webkit.org/attachment.cgi?id=24621&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
Looks good. r=me with some comments.

> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fixed bug 18703.  Text fields would not repaint themselves
> +	   after having their "size" attributes modified.  This modification 
> +	   tells the object to recalculate its width and repaint itself when 
> +	   its "size" attribute is parsed.

It is helpful to put the URL and title of the bug you are fixing in the
ChangeLog

> +	   if(renderer())
Space required after the if.

> +2008-10-23  Glenn Wilson  <gwilson at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Added a new text to verify that the width of text input 
> +	   fields can be modified by javascript using the "size" attribute.
Again, a URL and title help to give context.