[webkit-reviews] review requested: [Bug 21844] Remove setFocusRingColorChangeFunction() : [Attachment 24630] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 23 18:34:26 PDT 2008


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 21844: Remove setFocusRingColorChangeFunction()
https://bugs.webkit.org/show_bug.cgi?id=21844

Attachment 24630: patch v1
https://bugs.webkit.org/attachment.cgi?id=24630&action=edit

------- Additional Comments from Peter Kasting <pkasting at google.com>
Removing this function causes the Mac port to no longer hook up an observer
until focusRingColor() is called.  I don't think that can have a practical
effect, since focusRingColor() is the only way callers can actually get the
color the observer sets.  If anything, this makes the code (insignificantly)
more efficient.


More information about the webkit-reviews mailing list