[webkit-reviews] review granted: [Bug 21724] Correct Build Regressions (Win32-Cairo) : [Attachment 24478] Patch to correct build regressions in Cairo (Windows) build.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 22 10:11:28 PDT 2008

Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at gmail.com>'s request for review:
Bug 21724: Correct Build Regressions (Win32-Cairo)

Attachment 24478: Patch to correct build regressions in Cairo (Windows) build.

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
 8	   * WebCore.vcproj/WebCore.vcproj:  Correct paths for Cairo port.

I think it's helpful to say something along the lines of "Fixed include paths
and post-build event for the Debug_Cairo and Release_Cairo configurations and
added new Curl files."

 2  * Copyright (C) 2008 Collin Jackson  <collinj at webkit.org>

I don't think this copyright is needed (in DNSCurl.cpp).

 32 struct _CFURLRequest
 33 {
 34    int ignoreMe;
 35 };
 37 typedef const struct _CFURLRequest* CFURLRequestRef;

I think you can probably just do:

typedef const void* CFURLRequestRef;

Is there a reason why that won't work?

@@ HRESULT WebView::notifyPreferencesChange
41474147     hr = prefsPrivate->shouldPaintNativeControls(&enabled);
41484148     if (FAILED(hr))
41494149	 return hr;
41504151     settings->setShouldPaintNativeControls(!!enabled);
 4152 #endif

Should we skip the prefsPrivate call when SAFARI_THEME is disabled, too?

r=me, even if you don't address the above.

More information about the webkit-reviews mailing list