[webkit-reviews] review granted: [Bug 21757] Should not define PLATFORM(WIN, MAC, GTK) when PLATFORM(CHROMIUM) is defined : [Attachment 24553] v1.1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 22 08:15:46 PDT 2008


Eric Seidel <eric at webkit.org> has granted Darin Fisher (Google)
<darin at chromium.org>'s request for review:
Bug 21757: Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is
defined
https://bugs.webkit.org/show_bug.cgi?id=21757

Attachment 24553: v1.1 patch
https://bugs.webkit.org/attachment.cgi?id=24553&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  I think eventually much of this HAVE_* goop needs to move out of
Platform.h, but that's not really relevant to this patch.


More information about the webkit-reviews mailing list