[webkit-reviews] review requested: [Bug 21719] JS Profiler notification system needed : [Attachment 24512] Patch version 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 19 13:49:00 PDT 2008


Kevin Lindeman <klindeman at apple.com> has asked	for review:
Bug 21719: JS Profiler notification system needed
https://bugs.webkit.org/show_bug.cgi?id=21719

Attachment 24512: Patch version 4
https://bugs.webkit.org/attachment.cgi?id=24512&action=edit

------- Additional Comments from Kevin Lindeman <klindeman at apple.com>
I checked to make sure this worked in the "launch after we start" case
mentioned and it does.

The only thing that I wonder about with this patch is the if (!--listenerCount)
after we check to make sure we aren't 0 first - it works correctly, but looks
ugly. Any suggestions?


More information about the webkit-reviews mailing list