[webkit-reviews] review denied: [Bug 21719] JS Profiler notification system needed : [Attachment 24512] Patch version 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 19 14:19:19 PDT 2008


Timothy Hatcher <timothy at hatcher.name> has denied Kevin Lindeman
<klindeman at apple.com>'s request for review:
Bug 21719: JS Profiler notification system needed
https://bugs.webkit.org/show_bug.cgi?id=21719

Attachment 24512: Patch version 4
https://bugs.webkit.org/attachment.cgi?id=24512&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
You didn't need to remove the other early return, that would make the code less
ugly.

This is what you want:

+- (void)stopProfiling
+{
+    if (!listenerCount || --listenerCount > 0)
+	 return;
+    JSRetainPtr<JSStringRef> profileName(Adopt,
JSStringCreateWithUTF8CString([serverName UTF8String]));
+    JSEndProfiling(0, profileName.get());
+}


More information about the webkit-reviews mailing list